Open
Conversation
Deploying mfv2 with
|
| Latest commit: |
2c84abe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2da80d7.mfv2.pages.dev |
| Branch Preview URL: | https://cookbook.mfv2.pages.dev |
aphillips
reviewed
Mar 15, 2025
Comment on lines
+27
to
+30
| The denominator of the compact form is a power of 10. In US English, examples | ||
| are 1,000 (K), 1,000,000 (M), or 1,000,000,000 (B). In other locales, different | ||
| denominators may be used, which may not always be a power of 1000. In India, for | ||
| example, 1,00,000 (L) is used to represent 100,000. |
Member
There was a problem hiding this comment.
Use better line breaks. Semantic line breaks makes it easier to suggest edits, etc.
The examples (expecially the lakh example) is unclear. Perhaps:
Suggested change
| The denominator of the compact form is a power of 10. In US English, examples | |
| are 1,000 (K), 1,000,000 (M), or 1,000,000,000 (B). In other locales, different | |
| denominators may be used, which may not always be a power of 1000. In India, for | |
| example, 1,00,000 (L) is used to represent 100,000. | |
| For example, in US English (`en-US`) you might see: | |
| - `100,000` ⇒ `100K` | |
| - `1,000,000` ⇒ `1M` | |
| - `1,000,000,000` ⇒ `1B` | |
| Other locales have different rules or might use different default | |
| denominators. | |
| For example, English as used in India (`en-IN`) uses a different grouping strategy with units called "lakhs" and "crore": | |
| - `1,00,000` ⇒ `1L` | |
| - `10,00,000` ⇒ `10L` | |
| - `1,00,00,00,000` ⇒ `100Cr` |
Comment on lines
+24
to
+25
| Compact notation is a way of expressing large numbers in a more concise form. It | ||
| is commonly used in financial and scientific applications. |
Member
There was a problem hiding this comment.
I'm not so sure about scientific applications? Perhaps:
Suggested change
| Compact notation is a way of expressing large numbers in a more concise form. It | |
| is commonly used in financial and scientific applications. | |
| Compact notation is a way of expressing large numbers in a more concise form. | |
| This is useful for displaying numbers in environments with limited | |
| screen display space. |
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| title: Displaying percentages | |||
Member
There was a problem hiding this comment.
This is currently not in the spec, but may be added soon. The concern is that we might add a separate function.
Member
|
Cookbooks (like this PR) are an outstanding idea. |
bearfriend
reviewed
Mar 16, 2025
| one {{Je zde jeden prvek.}} | ||
| few {{Jsou zde {$count} prvky.}} | ||
| many {{Jsou zde {$count} prvků.}} | ||
| * {{Jsou zde {$count} prvků.}} |
There was a problem hiding this comment.
Should probably make other vs * more clear, but maybe that's better suited to a more complex example with multiple selectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a catalog of examples of how to do various things with MessageFormat 2. It is still relatively empty, but I hope that we can start filling this up with some more things collectively.
The idea here is for searches like "doing X with messageformat 2" to end up somewhere useful.
The best way to build a catalog like this is to look at Google Search console, see what people are looking for with "message format 2" in the query, and then make sure that frequent queries have a dedicated page. That requires having some decent traffic first though, so we need to seed it with examples that we think will be useful first.